app-template: remove production warning #2741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We print a warning when SEASTAR_DEBUG is enabled, saying it's not for production or performance testing. This might be a suitable warning for the application itself to emit, but a framework like seastar should leave that choice up to the application. This warning cannot be supressed and does not follow the normal logging system, so it is unnecessarily noisy and interferes with anything which parses stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We print a warning when SEASTAR_DEBUG is enabled, saying it's not for production or performance testing. This might be a suitable warning for the application itself to emit, but a framework like seastar should leave that choice up to the application. This warning cannot be supressed and does not follow the normal logging system, so it is unnecessarily noisy and interferes with anything which parses stderr.