Don't SetLatency() when it won't change the latency. (#516)

sdatkinson · web-flow · commit 646612380b37 · 2024-10-29T22:40:18.000-07:00
* Only _UpdateLatency() during OnReset() when sample rate changes

* SetLatency() only when setting with a different value
diff --git a/NeuralAmpModeler/NeuralAmpModeler.cpp b/NeuralAmpModeler/NeuralAmpModeler.cpp
@@ -890,7 +890,12 @@ void NeuralAmpModeler::_UpdateLatency()
     latency += mModel->GetLatency();
   }
   // Other things that add latency here...
-  SetLatency(latency);
+
+  // Feels weird to have to do this.
+  if (GetLatency() != latency)
+  {
+    SetLatency(latency);
+  }
 }
 
 void NeuralAmpModeler::_UpdateMeters(sample** inputPointer, sample** outputPointer, const size_t nFrames,

Original file line number	Diff line number	Diff line change
`@@ -890,7 +890,12 @@ void NeuralAmpModeler::_UpdateLatency()`
`890`	`890`	`latency += mModel->GetLatency();`
`891`	`891`	`}`
`892`	`892`	`// Other things that add latency here...`
`893`		`- SetLatency(latency);`
	`893`	`+`
	`894`	`+ // Feels weird to have to do this.`
	`895`	`+ if (GetLatency() != latency)`
	`896`	`+ {`
	`897`	`+ SetLatency(latency);`
	`898`	`+ }`
`894`	`899`	`}`
`895`	`900`
`896`	`901`	`void NeuralAmpModeler::_UpdateMeters(sample inputPointer, sample outputPointer, const size_t nFrames,`