[BUGFIX] Fix infinite loop in GUI update

synchu · Nikola Nyagolov · sdatkinson · web-flow · commit e2cd3b1081c6 · 2024-12-19T20:25:11.000-08:00
* Fixing issue #541 where NeuralAmpModelerPlugin causes plugin host(s) to crash and/or exit unexpectedly * Update NeuralAmpModelerControls.h SetDirty(false); --------- Co-authored-by: Nikola Nyagolov <nnyagolov@itnlbg.com> Co-authored-by: Steven Atkinson <steven@atkinson.mn>
diff --git a/NeuralAmpModeler/NeuralAmpModelerControls.h b/NeuralAmpModeler/NeuralAmpModelerControls.h
@@ -784,7 +784,8 @@ class NAMSettingsPageControl : public IContainerBaseWithNamedChildren
     {
       IControl::SetValueFromDelegate(normalizedValue, valIdx);
       const std::string s = ConvertToString(normalizedValue);
-      OnTextEntryCompletion(s.c_str(), valIdx);
+      SetStr(s.c_str());
+      SetDirty(false);
     };
 
   private:

Original file line number	Diff line number	Diff line change
`@@ -784,7 +784,8 @@ class NAMSettingsPageControl : public IContainerBaseWithNamedChildren`
`784`	`784`	`{`
`785`	`785`	`IControl::SetValueFromDelegate(normalizedValue, valIdx);`
`786`	`786`	`const std::string s = ConvertToString(normalizedValue);`
`787`		`- OnTextEntryCompletion(s.c_str(), valIdx);`
	`787`	`+ SetStr(s.c_str());`
	`788`	`+ SetDirty(false);`
`788`	`789`	`};`
`789`	`790`
`790`	`791`	`private:`