Add NAM-specific app wrapper #556
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @olilarkin! An alternative I see would be to go on a fork of the iPlug2 repo and make changes there. The main advantage is that the version control would have better continuity--this PR has lots of "green" which makes it hard to understand what the changes are (Can you lmk if there are any? Or is this just a copy-paste? Otherwise I'll have a look & Lmk your thoughts. |
|
It’s just a copy paste from the iPlug2/IPlug/App folder that is the code currently used by v0.7.3 its up to you… the app wrapper code is just code to host an IPlugApp … if i manage to land a much better app wrapper it shouldn’t be hard to switch back to use that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the iPlug2 APP wrapper code and duplicates it into /app, updating the Xcode and Visual Studio projects to use the NAM-specific code. This means that someone can fix e.g. #157 without having to fix the code in iPlug2 (which needs a more thorough reworking for flexible multichannel support).
It may also be necessary to do the same thing for IPlugAPP.h and IPlugAPP.cpp but I don't think so.