Update Github action workflow #79
Conversation
|
@NereusWB922 Thanks for this PR. Is this an urgent change or can we delay it till next semester? This branch will be put into use very soon (when CS2113 tP starts, so we need to decide now) |
I don't think it's urgent since the current version isn't causing any issues. We can delay it until next semester without any problems. |
|
@se-edu/tech-team-level1 For your review ... |
Let's add the following features to make this a minimal project template that students can use to start their project. * Gradle support, a basic build script * a skeleton JUnit test * a basic CheckStyle configuration * a basic I/O test setup * support for GitHub actions * documentation skeletons inside the docs folder In addition, let's remove the Gradle and JavaFX tutorials as they are not integral to a project template.
The latest version of Checkstyle is 10.2. At the same time, the checkstyle.xml file is slightly disorganised. Let's update the Checkstyle version in build.gradle, replace the checkstyle.xml file with the one used in AddressBook 3 and add a suppressions.xml file to support suppression of checks for test code for developers intending to use JUnit.
The oss-generic link for the coding standard is obsolete. At the same time, the description vaguely refers to a module. Let's change the coding standard link to the one used by SE-EDU and remove the reference to the module.
The latest minor release for Gradle 6 is 6.9.2. The latest version of the shadow plugin that is compatible with Gradle 6.9.2 is 6.1.0. Let's upgrade to Gradle 6.9.2 and shadow 6.1.0.
The latest version of Gradle is 7.4.2. The mainClassName property has been deprecated and replaced with the mainClass property. The latest shadow version compatible with Gradle 7.4.2 is 7.1.2. Let's upgrade to Gradle 7.4.2, resolve the deprecation and upgrade to shadow 7.1.2.
|
@NereusWB922 Looks like this PR got messed up after the target branch was rebased. Perhaps close this PR and PR again? |
NereusWB922
force-pushed
the
66-update-github-actions-workflow
branch
from
e3fb8a7 to
31aff38
Compare
|
@damithc Hi Prof, just rebased this branch onto the updated target branch. |
|
|
||
| - name: Merge to master | ||
| run: git checkout --progress --force ${{ github.sha }} | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
@NereusWB922 does the behavior remains the same here?
damithc
force-pushed
the
full-template
branch
from
a059f02 to
8e66470
Compare
Fixes #66
Bumps version:
Changes made: