Add GitHub Personal Access Token validity checks #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This utility class will be used to store the names of all the `X` headers from GitHub
This utility class only holds one `MediaType` specific to GitHub that we use in the app. Might be further extended in the future.
Also includes a new `GitHubHttpHeaders` value
Replaces `@PostConstruct`
This is encapsulated in the aptly named `GitHubTokenValidator`, and required some custom values in `GitHubHttpHeaders`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GitHubTokenManageris now anInitializingBean. Apart from the regular logging and init logic that was previously used in the@PostConstructmethod, it now also verifies that each specified token:reposcopeThis PR also introduces utilities for referencing GitHub-specific headers and media types.