Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trim starting character from path #1

Closed
wants to merge 1 commit into from

Conversation

slang25
Copy link

@slang25 slang25 commented Oct 21, 2018

While using this tool on macOS, I was passing in a pull path (/Users/stuart/git/...), in this scenario we don't want to remove the first character. I can see how this would save people from an error if they are entering a relative path, but the responsibility should be on them to enter it correctly IMO.

Great tool by the way!

@sebnilsson
Copy link
Owner

Thank you very much for finding this bug. The fix is a little bit too aggressive and will cause side-effects for Windows-users.

I've tried to update with a fix for the PATH-argument, to not trim the leading slash, but not for the clean-paths. Try out the new 0.5.2 version.

@sebnilsson sebnilsson closed this Oct 23, 2018
@slang25
Copy link
Author

slang25 commented Oct 23, 2018

Ah yes, I didn't see the other usage, that's much more appropriate. 0.5.2 fixes it 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants