Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geth upgrade test #2074

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

geth upgrade test #2074

wants to merge 12 commits into from

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Feb 14, 2025

Describe your changes and provide context

wip

Testing performed to validate your change

wip

@codchen codchen force-pushed the tony/integrate-geth-upgrade branch 2 times, most recently from 4c73b71 to 4c29f95 Compare February 17, 2025 04:16
return s.k.GetBalance(s.ctx, seiAddr)
res, overflow := uint256.FromBig(s.k.GetBalance(s.ctx, seiAddr))
if overflow {
panic("balance overflow")

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@codchen codchen force-pushed the tony/integrate-geth-upgrade branch from 4c29f95 to 9b4e161 Compare February 17, 2025 04:33
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 27.61506% with 346 lines in your changes missing coverage. Please review.

Project coverage is 61.11%. Comparing base (620c03b) to head (47468ef).

Files with missing lines Patch % Lines
x/evm/types/ethtx/set_code_tx.go 0.00% 174 Missing ⚠️
x/evm/types/ethtx/auth_list.go 0.00% 39 Missing ⚠️
app/eth_replay.go 0.00% 25 Missing ⚠️
x/evm/keeper/keeper.go 6.66% 14 Missing ⚠️
x/evm/module.go 0.00% 12 Missing and 1 partial ⚠️
x/evm/state/balance.go 58.62% 10 Missing and 2 partials ⚠️
x/evm/types/ethtx/set_code_tx_setter.go 0.00% 12 Missing ⚠️
x/evm/state/statedb.go 26.66% 11 Missing ⚠️
evmrpc/send.go 18.18% 9 Missing ⚠️
x/evm/keeper/genesis.go 0.00% 7 Missing ⚠️
... and 17 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
- Coverage   61.67%   61.11%   -0.57%     
==========================================
  Files         272      275       +3     
  Lines       25246    25575     +329     
==========================================
+ Hits        15571    15630      +59     
- Misses       8530     8791     +261     
- Partials     1145     1154       +9     
Files with missing lines Coverage Δ
app/receipt.go 86.63% <100.00%> (ø)
evmrpc/block.go 76.11% <100.00%> (ø)
evmrpc/state.go 48.83% <100.00%> (ø)
evmrpc/subscribe.go 66.66% <ø> (+0.64%) ⬆️
evmrpc/tracers.go 59.22% <100.00%> (ø)
evmrpc/txpool.go 73.80% <100.00%> (ø)
precompiles/common/precompiles.go 49.69% <100.00%> (+0.30%) ⬆️
x/evm/ante/basic.go 50.00% <100.00%> (ø)
x/evm/keeper/evm.go 69.67% <100.00%> (+0.19%) ⬆️
x/evm/keeper/pointer_upgrade.go 76.82% <100.00%> (+0.28%) ⬆️
... and 30 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/integrate-geth-upgrade branch 6 times, most recently from e47a311 to b34986e Compare February 18, 2025 12:58
@codchen codchen force-pushed the tony/integrate-geth-upgrade branch 3 times, most recently from c52b783 to e5e3cbc Compare March 10, 2025 08:11
_, err = statedb.Finalize()
if err != nil {
panic(err)
}
}
}
if am.keeper.EthBlockTestConfig.Enabled {
parentHash := common.BytesToHash(ctx.BlockHeader().LastBlockId.Hash)
blockCtx, err := am.keeper.GetVMBlockContext(ctx, core.GasPool(math.MaxUint64))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
parentHash := common.BytesToHash(ctx.BlockHeader().LastBlockId.Hash)
blockCtx, err := am.keeper.GetVMBlockContext(ctx, core.GasPool(math.MaxUint64))
if err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
statedb := state.NewDBImpl(ctx, am.keeper, false)
vmenv := vm.NewEVM(*blockCtx, statedb, types.DefaultChainConfig().EthereumConfig(am.keeper.ChainID(ctx)), vm.Config{}, am.keeper.CustomPrecompiles())
core.ProcessParentBlockHash(parentHash, vmenv)
_, err = statedb.Finalize()

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
core.ProcessParentBlockHash(parentHash, vmenv)
_, err = statedb.Finalize()
if err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@codchen codchen force-pushed the tony/integrate-geth-upgrade branch from 5a6f46a to 17e5859 Compare March 11, 2025 12:48
@codchen codchen force-pushed the tony/integrate-geth-upgrade branch 2 times, most recently from 0e37bdc to 83ebdf3 Compare April 2, 2025 04:08
@codchen codchen force-pushed the tony/integrate-geth-upgrade branch from 83ebdf3 to 47468ef Compare April 2, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants