Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite block hash in tracer response with tendermint block hash #2117

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Mar 31, 2025

Describe your changes and provide context

related issue: #2116
tracer endpoints were incorrectly using the RLP hash as the block hash in responses. This PR changes the logic so that the tendermint block hash is used to overwrite the block hash in responses.

Testing performed to validate your change

unit test

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.67%. Comparing base (7fb0cbc) to head (ab7cb83).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files         272      272           
  Lines       25242    25246    +4     
=======================================
+ Hits        15568    15571    +3     
- Misses       8528     8530    +2     
+ Partials     1146     1145    -1     
Files with missing lines Coverage Δ
evmrpc/simulate.go 70.68% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen merged commit 620c03b into main Apr 1, 2025
49 of 50 checks passed
@codchen codchen deleted the tony/tracer-overwrite-block-hash branch April 1, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants