-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM documentation improvements #76
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4612c80
Docs for EVM related structs and functions
dssei 7d2f302
uncomment attr
dssei 0ec518b
fix formatting
dssei 9eebf58
add more clarity what Sei address is. The Sei address is a native Sei…
dssei 8f5f9e5
further clarification -> bech32-encoded 'sei*' address
dssei df04758
address some other comments
dssei 84a0646
address more comments
dssei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,14 +41,29 @@ pub enum SeiMsg { | |
SetMetadata { | ||
metadata: Metadata, | ||
}, | ||
/// Calls EVM contract deployed at `to` address with the given `data`. | ||
/// Calls EVM contract as if the contract's caller called it directly. | ||
/// Please note that the CW contract has to be in | ||
/// [allow list](https://github.com/sei-protocol/sei-chain/blob/seiv2/x/evm/types/params.go#L142) | ||
/// in order to execute delegate call. | ||
/// The EVM (Solidity) contract `msg.sender` in this case will be the callers address. | ||
DelegateCallEvm { | ||
/// The address of the EVM contract to call | ||
to: String, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Assuming this is hex-encoded, do these require the capitalization checksums? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no it doesn't |
||
data: String, // base64 encoded | ||
/// Base64 encoded binary data to pass to the contract | ||
data: String, | ||
}, | ||
/// Calls EVM contract deployed at `to` address with specified `value` and `data`. | ||
/// The from address is the contract address of the contract executing the call. | ||
/// The EVM (Solidity) contract `msg.sender` in this case will be the 32-byte long | ||
/// [`cosmwasm_std::CanonicalAddr`] of this contract. | ||
CallEvm { | ||
/// The amount to send along with the transaction | ||
value: Uint128, | ||
/// The address of the EVM contract to call | ||
to: String, | ||
data: String, // base64 encoded | ||
/// Base64 encoded binary data to pass to the contract | ||
data: String, | ||
}, | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to link to the differences between how "sei*" and "0x*" addresses are trans-coded for humans vs contracts everywhere "the callers address" is mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@besated do you know if we already have a sei doc page for address mapping? If not I can help with writing up one (not sure where the gitbook repo is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have this section in the docs - https://v2.docs.sei.io/setting-up-a-wallet#advanced
if you want to add more details, you can create a pr in the
sei-docs
repo