Skip to content

Improve SeiDB replay&restart time by 2x #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions sc/memiavl/multitree.go
Original file line number Diff line number Diff line change
Expand Up @@ -339,19 +339,38 @@ func (t *MultiTree) Catchup(stream types.Stream[proto.ChangelogEntry], endVersio
return fmt.Errorf("target index %d is in the future, latest index: %d", endIndex, lastIndex)
}

var replayCount = 0
err = stream.Replay(firstIndex, endIndex, func(index uint64, entry proto.ChangelogEntry) error {
if err := t.apply(entry); err != nil {
return fmt.Errorf("apply rlog entry failed, %w", err)
if err := t.ApplyUpgrades(entry.Upgrades); err != nil {
return err
}
updatedTrees := make(map[string]bool)
for _, cs := range entry.Changesets {
treeName := cs.Name
t.TreeByName(treeName).ApplyChangeSetAsync(cs.Changeset)
updatedTrees[treeName] = true
}
if _, err := t.SaveVersion(false); err != nil {
return fmt.Errorf("replay changeset failed to save version, %w", err)
for _, tree := range t.trees {
if _, found := updatedTrees[tree.Name]; !found {
tree.ApplyChangeSetAsync(iavl.ChangeSet{})
}
}
t.lastCommitInfo.Version = utils.NextVersion(t.lastCommitInfo.Version, t.initialVersion)
t.lastCommitInfo.StoreInfos = []proto.StoreInfo{}
replayCount++
if replayCount%1000 == 0 {
fmt.Printf("Replayed %d changelog entries\n", replayCount)
}
return nil
})

for _, tree := range t.trees {
tree.WaitToCompleteAsyncWrite()
}

if err != nil {
return err
}

t.UpdateCommitInfo()
return nil
}
Expand Down
47 changes: 40 additions & 7 deletions sc/memiavl/tree.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
var _ types.Tree = (*Tree)(nil)
var emptyHash = sha256.New().Sum(nil)

// verify change sets by replay them to rebuild iavl tree and verify the root hashes
// Tree verify change sets by replay them to rebuild iavl tree and verify the root hashes
type Tree struct {
version uint32
// root node of empty tree is represented as `nil`
Expand All @@ -31,6 +31,9 @@

// sync.RWMutex is used to protect the tree for thread safety during snapshot reload
mtx *sync.RWMutex

pendingChanges chan iavl.ChangeSet
pendingWg *sync.WaitGroup
}

// NewEmptyTree creates an empty tree at an arbitrary version.
Expand All @@ -43,8 +46,9 @@
version: uint32(version),
initialVersion: initialVersion,
// no need to copy if the tree is not backed by snapshot
zeroCopy: true,
mtx: &sync.RWMutex{},
zeroCopy: true,
mtx: &sync.RWMutex{},
pendingWg: &sync.WaitGroup{},
}
}

Expand All @@ -62,10 +66,11 @@
// NewFromSnapshot mmap the blob files and create the root node.
func NewFromSnapshot(snapshot *Snapshot, zeroCopy bool, _ int) *Tree {
tree := &Tree{
version: snapshot.Version(),
snapshot: snapshot,
zeroCopy: zeroCopy,
mtx: &sync.RWMutex{},
version: snapshot.Version(),
snapshot: snapshot,
zeroCopy: zeroCopy,
mtx: &sync.RWMutex{},
pendingWg: &sync.WaitGroup{},
}

if !snapshot.IsEmpty() {
Expand Down Expand Up @@ -116,6 +121,31 @@
}
}

func (t *Tree) ApplyChangeSetAsync(changeSet iavl.ChangeSet) {
if t.pendingChanges == nil {
t.StartBackgroundWrite()
}
t.pendingChanges <- changeSet
}

func (t *Tree) StartBackgroundWrite() {
t.pendingWg.Add(1)
t.pendingChanges = make(chan iavl.ChangeSet, 1000)
go func() {
defer t.pendingWg.Done()
for nextChange := range t.pendingChanges {
t.ApplyChangeSet(nextChange)
_, _, _ = t.SaveVersion(false)
}
}()
}

func (t *Tree) WaitToCompleteAsyncWrite() {
close(t.pendingChanges)
t.pendingWg.Wait()
t.pendingChanges = nil
}

func (t *Tree) Set(key, value []byte) {
t.mtx.Lock()
defer t.mtx.Unlock()
Expand Down Expand Up @@ -270,6 +300,9 @@
err = t.snapshot.Close()
t.snapshot = nil
}
if t.pendingChanges != nil {
close(t.pendingChanges)
}
t.root = nil
return err
}
Expand Down
1 change: 0 additions & 1 deletion ss/pebbledb/db.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ func (db *Database) SetLatestVersion(version int64) error {
var ts [VersionSize]byte
binary.LittleEndian.PutUint64(ts[:], uint64(version))
err := db.storage.Set([]byte(latestVersionKey), ts[:], defaultWriteOpts)
fmt.Printf("SetLatestVersion: version=%d, err=%v, latestVersionKey=%s\n", version, err, latestVersionKey)
return err
}

Expand Down
Loading