Merge pull request #43 from seomoz/dan/javascript-mailto-and-friends

Handle javascript, mailto, and friends
seomoz · Aug 4, 2016 · 3d5fb66 · 3d5fb66
2 parents 0215c7c + a23a434
commit 3d5fb66
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -3,7 +3,7 @@ test: url/url.so
 	# TODO(dan): coverage with Cython
 	nosetests --verbose
 
-url/url.so: url/url.cpp url/url.pyx url/url.pxd
+url/url.so: url/url.cpp url/url.pyx url/url.pxd url/url-cpp/src/*.cpp url/url-cpp/include/*.h
 	python setup.py build_ext --inplace
 
 install:

diff --git a/test.py b/test.py
@@ -506,6 +506,12 @@ def test(rel, absolute):
         yield test, rel, absolute
 
 
+def test_relative_javascript():
+    rel = 'javascript:console.log("hello")'
+    base = 'http://foo.com/path'
+    assert_equal(rel, url.parse(rel).relative_to(base).utf8)
+
+
 def test_sanitize():
     def test(bad, good):
         assert_equal(url.parse(bad).sanitize().utf8, good)

diff --git a/url/url-cpp b/url/url-cpp
+3 −0		include/url.h
+101 −9		src/url.cpp
+124 −19		test/test-url.cpp