Skip to content

[MISC] Move std::exit for special formats to parser #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Apr 24, 2023

Exit in the parse() function instead of in the format itself. Arguably a better design. May also be needed for #173

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sharg-parser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 1:44pm

@eseiler eseiler requested a review from smehringer April 24, 2023 13:44
@seqan-actions seqan-actions added lint [INTERNAL] signals that clang-format ran and removed lint [INTERNAL] signals that clang-format ran labels Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f0b5fc3) 92.30% compared to head (66fa140) 92.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          16       16           
  Lines        1442     1443    +1     
=======================================
+ Hits         1331     1332    +1     
  Misses        111      111           
Impacted Files Coverage Δ
include/sharg/detail/format_base.hpp 92.93% <ø> (-0.04%) ⬇️
include/sharg/detail/format_help.hpp 89.56% <ø> (ø)
include/sharg/parser.hpp 99.54% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@smehringer smehringer merged commit 14d0df8 into seqan:main Apr 25, 2023
@eseiler eseiler deleted the misc/format_exit branch April 25, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants