Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking payment method availability #20

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Fix checking payment method availability #20

merged 2 commits into from
Jun 6, 2024

Conversation

MarijaIv
Copy link
Collaborator

What is the goal?

If SeQura payment methods are not available for the selling country, the plugin shouldn't throw an error.

How is it being implemented?

try ... catch has been added to CreateOrderRequestBuilder. Additional validation has been added to check if order request should be created.

Does it affect (changes or update) any sensitive data?

No.

How is it tested?

Manual test.
Steps:

  • In plugin, configure only Spain.
  • Go to checkout and enter any other country for shipping address.
  • Result: there is no error in the logs.

How is it going to be deployed?

Standard deployment.

Copy link
Contributor

@mescalantea mescalantea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m1k3lm m1k3lm merged commit 2b0e612 into master Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants