Add dependency to PageBuilder #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSUE: CS-5513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal?
We have reviewed the PR and came to the conclusion that it is not safe to merge it.
The dependency to the ProviderInterface is necessary for the WidgetConfig class in order for widget preview to work. If we remove the dependency, widgets preview will not work in Magento’s backoffice, therefore the merchants that want to use widgets will not be able to configure them.
Instead, we have added the dependency to the Magento_PageBuilder to the module, because with the current implementation, this is correct.
However, this would prevent merchants that have Magento shop’s without page builder from installing the module and using the payment methods in checkout. We would need input from SeQura team how we should handle this issue. We could remove widgets implementation from the core module version and create a new module for widgets functionality. However, we would need to further analyze this, since it would be a big change, and that should be a change request.
How is it being implemented?
Added dependency to Magento_PageBuilder in module.xml file.
Does it affect (changes or update) any sensitive data?
No.
How is it tested?
Manual test. Install module via composer.
How is it going to be deployed?
Standard deployment.