Update docker image #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal?
Update docker image
How is it being implemented?
This pull request includes several changes to the
build-image.sh,.env.sample,README.md, andsetup.shfiles to support a new Magento version and improve the documentation and setup process. The most important changes include adding support for Magento version 2.4.7-p4, updating the.env.samplefile, enhancing the debugging instructions in theREADME.md, and removing the--buildoption from the setup script.Support for new Magento version:
.docker/magento/build-image.sh: Added support for Magento version 2.4.7-p4 in the argument parsing, version checking, and compatibility checks. [1] [2] [3].env.sample: Added Magento version 2.4.7-p4 as a sample version.Documentation improvements:
README.md: Added a section for debugging with XDebug, including instructions for creating a VS Code Workspace file and starting the debugger.Setup script changes:
setup.sh: Removed the--buildoption from the setup script and its associated logic. [1] [2]How is it tested?
Manual tests
How is it going to be deployed?
Standard deployment