Skip to content

Add SEO component to pages and remove inline meta tags for improved SEO management #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mattgianni
Copy link
Collaborator

The SEO component provides us the ability to adjust the SEO meta tags on a per page basis. I've added new descriptions/titles for the various pages within the application, but it would be good to get the design team's input here.

Copy link

vercel bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
support-sfusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 10:19pm

@mattgianni mattgianni requested a review from Copilot April 14, 2025 22:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a centralized SEO component to manage meta tags across the application while removing redundant inline meta tag definitions from pages and the document.

  • Added a new SEO component (src/components/SEO.tsx) to handle page metadata.
  • Updated pages (school.tsx, map.tsx, index.tsx, about.tsx) to use the SEO component instead of inline meta tags.
  • Removed legacy inline meta tag definitions from _document.tsx in favor of SEO component usage.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/pages/school.tsx Added SEO integration for dynamic page title and description.
src/pages/map.tsx Introduced SEO component and minor formatting adjustments.
src/pages/index.tsx Integrated SEO with a custom title.
src/pages/about.tsx Added SEO component and tidied up multi-line text formatting.
src/pages/_document.tsx Removed inline meta tags; added analytics script.
src/components/SEO.tsx New SEO component to streamline metadata management across pages.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mattgianni mattgianni added the enhancement New feature or request label Apr 14, 2025
@mattgianni mattgianni linked an issue Apr 14, 2025 that may be closed by this pull request
@mattgianni mattgianni moved this to In Review in Support SFUSD Apr 14, 2025
@mattgianni mattgianni requested a review from nickvisut April 14, 2025 22:48
@BeeSeeWhy BeeSeeWhy self-requested a review April 24, 2025 19:46
Copy link
Collaborator

@BeeSeeWhy BeeSeeWhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good....may want another eye on it as well though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

[Feature]: improve page metadata for SEO
2 participants