disable autoflake precommit and fix URL encoding

colab link issue

Author: sgbaird

.pre-commit-config.yaml

@@ -25,16 +25,17 @@ repos:
 #   - id: pyupgrade
 #     args: ['--py37-plus']
 
-# If you want to avoid flake8 errors due to unused vars or imports:
-- repo: https://github.com/PyCQA/autoflake
-  rev: v2.3.0
-  hooks:
-  - id: autoflake
-    args: [
-      --in-place,
-      --remove-all-unused-imports,
-      # --remove-unused-variables,
-    ]
+# # If you want to avoid flake8 errors due to unused vars or imports:
+# Failing due to
+# - repo: https://github.com/PyCQA/autoflake
+#   rev: v2.3.0
+#   hooks:
+#   - id: autoflake
+#     args: [
+#       --in-place,
+#       --remove-all-unused-imports,
+#       # --remove-unused-variables,
+#     ]
 
 - repo: https://github.com/PyCQA/isort
   rev: 5.13.2

scripts/generate_scripts.py

@@ -281,8 +281,12 @@ def is_incompatible(opt):
         "https://colab.research.google.com/github/sgbaird/honegumi/blob/main/"
     )
 
-    notebook_path = path.join(GEN_NOTEBOOK_DIR, f"{rendered_template_stem}.ipynb")
-    colab_link = urljoin(colab_prefix, notebook_path)
+    notebook_fname = f"{rendered_template_stem}.ipynb"
+    notebook_path = path.join(GEN_NOTEBOOK_DIR, notebook_fname)
+    # HACK: issue with + encoding becoming %20 instead of %2B due to use of \\
+    # instead of / Alternative is using:
+    # `encoded_notebook_fname = quote(notebook_fname)`
+    colab_link = urljoin(colab_prefix, notebook_path).replace("\\", "/")
     colab_badge = f'<a href="{colab_link}"><img alt="Open In Colab" src="https://colab.research.google.com/assets/colab-badge.svg"></a>'  # noqa E501
 
     preamble = f"{colab_badge} {github_badge}"