Skip to content

Remove VCF header #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

tomwhite
Copy link
Contributor

Fixes sgkit-dev/bio2zarr#184

This needs sgkit-dev/bio2zarr#352 (from bio2zarr). This is not working yet as it exposes some corner cases in the VCF conversion that may be bugs. I'll open issues for these in bio2zarr.

@jeromekelleher
Copy link
Contributor

This would be a great step forward!

I wonder if we should try and get the rest of the header fields in to Zarr first in bio2zarr, so that we can more-or-less round-trip?

@tomwhite
Copy link
Contributor Author

I wonder if we should try and get the rest of the header fields in to Zarr first in bio2zarr, so that we can more-or-less round-trip?

We don't need to tie them together - would be OK to do them separately I think.

@jeromekelleher
Copy link
Contributor

Looks like you've dug out enough bugs to keep us going for a while in any case!

@tomwhite
Copy link
Contributor Author

All tests pass locally with the latest changes from sgkit-dev/bio2zarr#360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants