-
Notifications
You must be signed in to change notification settings - Fork 5
Remove VCF header #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove VCF header #198
Conversation
This would be a great step forward! I wonder if we should try and get the rest of the header fields in to Zarr first in bio2zarr, so that we can more-or-less round-trip? |
Here are the bugs I found: |
We don't need to tie them together - would be OK to do them separately I think. |
Looks like you've dug out enough bugs to keep us going for a while in any case! |
809028c
to
7b76e22
Compare
All tests pass locally with the latest changes from sgkit-dev/bio2zarr#360 |
Fixes sgkit-dev/bio2zarr#184
This needs sgkit-dev/bio2zarr#352 (from bio2zarr). This is not working yet as it exposes some corner cases in the VCF conversion that may be bugs. I'll open issues for these in bio2zarr.