-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ਕਾਰ when there is no whitespace #62
Comments
@irvanjitsingh have you had a chance to try this? |
Tried it out in OpenOffice, it still doesn't work well for all mangal variations, like the one commonly found in sundar gutka>chaupaee sahib. Example from Sarabloh Granth found on GurmatVeechar.com: ![]() ![]() I wonder if the kaar can be rendered differently if the proceeding word has a ੀ. It might also be useful to add an alternative ik oangkaar with a much largar kaar that should only be rendered when the webpage/document doesn't have any other content in the lines above. |
Personally, my thought is the kaar does not need to loop that big and point to the start of ਵ. It's difficult to try and look exactly like all the written saroops because of all the varying styles they have. I'm thinking that this is perhaps a subjective issue more than an objective one. Honestly, as far as this font has developed, I can now give some objective reasons why Sant Lipi in your picture looks a lot better than what I typically see being used for the same line. Could you do a side by side comparison of the different fonts in OpenOffice? I would recommend using some popularly used fonts both ascii and unicode such as web akhar thick, google's noto, mukta mahee, etc. If you have some other good examples, feel free to include those. I will include what I see on the web here, which will probably have some good overlap. Also could you open a PR that adds your example from sarabloh granth to the last two entries in https://shabados.github.io/SantLipi/qa/test/doubledanda.html (found at the bottom of https://github.com/shabados/SantLipi/blob/main/scripts/tests/tests.py)? That should help us compare the different styles digitally. Another important consideration is when you have to render ik oankar in the middle of an ang between multiple lines. In these cases, the large loop you're suggesting would not work at all. For example near the middle of the fifth line here: ![]() Attaching some examples of popular websites here. Honestly I think most of the community should be able to switch over to Sant Lipi already as an ulterior font choice. And worth pointing out the development of Sant Lipi far outpaces the development of other fonts. Waiting for perfection is counter to what is already on display, wouldn't you agree?
GurbaniNow / @sarabveer (unicode): Gursevak's readgurbani.com (basically bold version of gursevak.com, note intersection): Other sites pretty much fall under one of the above such as SGPC, STTM, Guru Granth Darpan, Khoj Gurbani. In my honest opinion, I can't argue against Sant Lipi in this regard. The only one out of the list I have here that seems like a contender is SearchGurbani which brings the kar before the bihari. The examples from SriGranth and Gursevak actually are quite similar to Sant Lipi already, except it seems Sant Lipi can handle variable font-weights better. |
I should clarify: I'm really impressed by rapid development here. We are really considering adopting SantLipi, and may do so if sevadaars (designers included), approve. My motivation for opening these issues is to help further improve this font for everyone that does use it, and those that may choose to in the future. If you prefer not to shorten the kaar further like the SearchGurbani example, then maybe adding a bit of spacing like the ASCII fonts have, would work. |
Not promising any development on this just yet, will still think through this some more. But will re-open the issue for tracking. My current idea is to see if we can reshape based on bihari in the sequence. One thing you can do to help is collate a list of all ik oankar usage that we want to design for. That way I know more of the variables in context. Also if you can open a PR that adds them to the test suite, that would help as well. Edit: Can reshape based on bihari, can add spacing by reducing right from -535/-457, against concept of larivar
|
Originally posted by @irvanjitsingh in #53 (comment)
The text was updated successfully, but these errors were encountered: