Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight of LDI instruction #1

Open
pixelsyntax opened this issue Aug 19, 2019 · 1 comment
Open

Highlight of LDI instruction #1

pixelsyntax opened this issue Aug 19, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pixelsyntax
Copy link

Thanks for making this great package. I have one problem: LDI instruction not highlighted correctly.

Steps to reproduce:

  • Install sublime_z80_rgbds via Package Manager in Sublime Text 3
  • Open or create a file configured to use RGBDS syntax highlighting
  • Enter a line of code using the LDI instruction, for example
    LDI [HL], A

Expected result:
LDI is recognised as an instruction and has the main 'stuff for the cpu' highlighting context applied

Actual result:
LD is highlighted correctly, but the terminating 'I' character is not.

I've only noticed this problem with LDI. LDD and LDH are unaffected, no idea why this happens!

Example screenshot attached
Screen Shot 2019-08-20 at 9 44 21 am

@shinmai shinmai self-assigned this Aug 25, 2019
@shinmai shinmai added the bug Something isn't working label Aug 25, 2019
@shinmai
Copy link
Owner

shinmai commented Aug 25, 2019

Thanks for this, I initially scraped the definitions together quite quickly, just to have some kind of highlighting for my rgbds sources, and have since read the rgbds docs and assembler source more thoroughly, to fix a few other similar oversights in the current, quite crude definitions.
Sorry for the delay, I'm in the process of migrating my e-mails over to a new address and had failed to change my GitHub account e-mail. I'll try and have a new version of the package pushed out by next weekend, to address this and a few other annoying quirks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants