Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dependency #1

Open
shivamgpt38 opened this issue Oct 3, 2019 · 9 comments
Open

Update the dependency #1

shivamgpt38 opened this issue Oct 3, 2019 · 9 comments

Comments

@shivamgpt38
Copy link
Owner

Hi there first timers,

Here is a simple task for you.
I haven't updated the dependency and code for a while and it can be improve. So Pull this repo and update and fix what ever you feel like fixing. and push to merge.

All the best,
Shivam Gupta

@NeonNature
Copy link
Contributor

May I take this issue? ^^

@BrandonMGH
Copy link

I am going to work on this if that's okay?

@shivamgpt38
Copy link
Owner Author

@NeonNature Sure go ahead.
@BrandonMGH See if you can change something like updating the syntax or improving the application itself.

This code is very old. So do whatever you feel like.

@dennypradipta
Copy link
Contributor

Oh man I forgot to reply to this issue. I am already working on it

@NeonNature
Copy link
Contributor

#2

I'm wondering why node_modules was added since they are usually included in .gitignore

@dennypradipta
Copy link
Contributor

I did npm audit fix, updated Express and Mongoose to current version. I also fixed the database connection using some of the settings recommended by Mongoose in order to hide warning messages about deprecation.

Also, I updated the bootstrap and the layout of the page. Not so much difference though, but at least it has some responsiveness now.

Maybe the PR from @NeonNature will conflict my PR if you approved his PR, so let me know when I should fix the merge conflicts.

Thanks

@shivamgpt38
Copy link
Owner Author

@dennypradipta i have merged @NeonNature PR. So please go ahead and check if is there any conflict.

@dennypradipta
Copy link
Contributor

Ok I forked again, and made some changes. Take a look

@shivamgpt38
Copy link
Owner Author

Thank you for your contribution guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants