Fix invalid date handling in cron occurrence calculation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where the cron occurrence calculation could attempt to create invalid dates, such as February 29th in non-leap years. The changes include: - Combining two separate checks for day_of_month validity into a single condition for efficiency. - Implementing a helper method __is_valid_date to verify date validity. - Ensuring that when an invalid date is encountered, the calculation moves to the next month and continues the search. - Added test cases to cover this change.
siddarth-patil
deleted the
11-bug-valueerror-day-is-out-of-range-for-month
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the #11 issue.
This commit addresses an issue where the cron occurrence calculation could attempt to create invalid dates, such as February 29th in non-leap years. The changes include: