[15] Bug Fix for infinite loop while trying to get next or prev occurrence #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence - Updated `day_of_month_regex` to only allow `L-1` to `L-30` and exclude `L-31`. - Updated `__find_once` and `__find_prev_once` to break infinite loop by returning `None`. - Added `__is_valid_date` validation inside `__find_prev_once` method to make sure valid date is returned. - Added required test cases. - Patch version Bump
- Getting rid of `UTC` and `datetime` import as they are not supported in Python 38,39, and 310
siddarth-patil
deleted the
15-bug-infinite-loop-in-aws-cron-expression-parsing-with-invalid-l--syntax
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #15
day_of_month_regexto only allowL-1toL-30and excludeL-31.__find_onceand__find_prev_onceto break infinite loop by returningNone.__is_valid_datevalidation inside__find_prev_oncemethod to make sure valid date is returned.