CA Tool Sonar issue fixes

src/ArtifactoryUploader/ArtifactoryUploader.cs

@@ -95,7 +95,7 @@ async Task<AqlResult> TryGetPackageInfo(ComponentsToArtifactory component)
 
 
             // Handle DEBIAN package name mismatch
-            if (component.ComponentType == "DEBIAN" && packageInfo?.Name != component.JfrogPackageName)
+            if (component.ComponentType == "DEBIAN" && packageInfo != null && packageInfo.Name != component.JfrogPackageName)
             {
                 component.CopyPackageApiUrl = component.CopyPackageApiUrl.Replace(component.JfrogPackageName, packageInfo.Name);
             }

src/ArtifactoryUploader/JfrogRepoUpdater.cs

@@ -28,7 +28,7 @@ public static async Task<Bom> UpdateJfrogRepoPathForSucessfullyUploadedItems(Bom
             List<ComponentsToArtifactory> uploadedPackages = PackageUploadInformation.GetUploadePackageDetails(displayPackagesInfo);
 
             // Get the details of all the dest repo names from jfrog at once
-            List<string> destRepoNames = uploadedPackages.Select(x => x.DestRepoName)?.Distinct()?.ToList() ?? new List<string>();
+            List<string> destRepoNames = uploadedPackages.Select(x => x.DestRepoName).Distinct().ToList();
             List<AqlResult> jfrogPackagesListAql = await GetJfrogRepoInfoForAllTypePackages(destRepoNames);
 
             // Update the repo path

src/LCT.Common/TelemetryHelper.cs

@@ -31,7 +31,7 @@ public TelemetryHelper(CommonAppSettings appSettings)
 
             telemetry_ = new LCT.Telemetry.Telemetry(TelemetryConstant.Type, new Dictionary<string, string>
                 {
-                { "InstrumentationKey", appSettings.Telemetry.ApplicationInsightInstrumentKey }
+                { "InstrumentationKey", appSettings?.Telemetry?.ApplicationInsightInstrumentKey ?? string.Empty }
             });
         }
 

src/LCT.PackageIdentifier/ConanProcessor.cs

@@ -392,8 +392,18 @@ private static void GetPackagesForBom(ref List<Component> lstComponentForBOM, re
 
             ConanPackage package = nodePackages.Where(x => x.Id == "0").FirstOrDefault();
             List<string> directDependencies = new List<string>();
-            if (package.Dependencies != null) { directDependencies.AddRange(package.Dependencies); }
-            if (package.DevDependencies != null) { directDependencies.AddRange(package.DevDependencies); }
+            if (package != null)
+            {
+                if (package.Dependencies != null)
+                {
+                    directDependencies.AddRange(package.Dependencies);
+                }
+
+                if (package.DevDependencies != null)
+                {
+                    directDependencies.AddRange(package.DevDependencies);
+                }
+            }
 
             // Ignoring the root node as it is the package information node and we are anyways considering all
             // nodes in the lock file.

src/LCT.PackageIdentifier/MavenProcessor.cs

@@ -222,7 +222,7 @@ public async Task<List<Component>> GetJfrogRepoDetailsOfAComponent(List<Componen
                 AqlResult finalRepoData = GetJfrogArtifactoryRepoDetials(aqlResultList, component, bomhelper, out jfrogRepoPath);
                 Property siemensfileNameProp = new() { Name = Dataconstant.Cdx_Siemensfilename, Value = finalRepoData?.Name ?? Dataconstant.PackageNameNotFoundInJfrog };
                 Property jfrogRepoPathProp = new() { Name = Dataconstant.Cdx_JfrogRepoPath, Value = jfrogRepoPath };
-                Property artifactoryrepo = new() { Name = Dataconstant.Cdx_ArtifactoryRepoName, Value = finalRepoData.Repo };
+                Property artifactoryrepo = new() { Name = Dataconstant.Cdx_ArtifactoryRepoName, Value = finalRepoData?.Repo };
 
                 Component componentVal = component;
                 if (artifactoryrepo.Value == appSettings.Maven.DevDepRepo)
@@ -383,7 +383,10 @@ private static AqlResult GetJfrogArtifactoryRepoDetials(List<AqlResult> aqlResul
                 aqlResult = aqlResults.FirstOrDefault(x => x.Repo.Equals(repoName));
                 jfrogRepoPath = GetJfrogRepoPath(aqlResult);
             }
-            aqlResult.Repo ??= repoName;
+            if (aqlResult != null)
+            {
+                aqlResult.Repo ??= repoName;
+            }
             return aqlResult;
         }
 

src/LCT.PackageIdentifier/NpmProcessor.cs

@@ -693,7 +693,10 @@ public AqlResult GetJfrogArtifactoryRepoDetials(List<AqlResult> aqlResultList,
                 jfrogRepoPath = GetJfrogRepoPath(aqlResult);
             }
 
-            aqlResult.Repo ??= NotFoundInRepo;
+            if (aqlResult != null)
+            {
+                aqlResult.Repo ??= NotFoundInRepo;
+            }
             return aqlResult;
         }
 

src/LCT.PackageIdentifier/NugetDevDependencyParser.cs

@@ -184,7 +184,7 @@ private static void GetDirectDependencies(string filePath)
             var readValue = File.ReadAllText(filePath);
             JObject serializedContent = JObject.Parse(readValue);
             JToken projectFramworks = serializedContent["project"]["frameworks"];
-            if (projectFramworks == null && !projectFramworks.HasValues)
+            if (projectFramworks == null || !projectFramworks.HasValues)
             {
                 return;
             }
@@ -203,7 +203,7 @@ private static void GetDirectDependencies(string filePath)
 
                 if (projectDependencies.HasValues)
                 {
-                    directDepCollection = projectDependencies.Children().OfType<JProperty>()?.ToList() ?? new List<JProperty>();
+                    directDepCollection = projectDependencies.Children().OfType<JProperty>().ToList();
                 }
                 foreach (var child in directDepCollection)
                 {

src/LCT.PackageIdentifier/NugetProcessor.cs

@@ -338,7 +338,10 @@ public AqlResult GetJfrogArtifactoryRepoDetials(List<AqlResult> aqlResultList,
                 aqlResult = aqlResults.FirstOrDefault(x => x.Repo.Equals(repoName));
                 jfrogRepoPath = GetJfrogRepoPath(aqlResult);
             }
-            aqlResult.Repo ??= repoName;
+            if (aqlResult != null)
+            {
+                aqlResult.Repo ??= repoName;
+            }
             return aqlResult;
         }
 

src/LCT.SW360PackageCreator/CreatorValidator.cs

@@ -85,7 +85,7 @@ public static async Task TriggerFossologyValidation(CommonAppSettings appSetting
                         else
                         {
                             int currentPage = page;
-                            int totalPages = (int)(releaseResponse?.Page?.TotalPages);
+                            int totalPages = (int)(releaseResponse?.Page?.TotalPages ?? 0);
                             if (currentPage < totalPages - 1)
                             {
                                 page = currentPage + 1;