Skip to content

Commit

Permalink
refactor(core): reduce strict errors (#1661)
Browse files Browse the repository at this point in the history
Co-authored-by: Andreas Berliner <andreas.berliner@siemens.com>
  • Loading branch information
danielleroux and AndreasBerliner authored Jan 22, 2025
1 parent 906172a commit 6e41ae3
Show file tree
Hide file tree
Showing 84 changed files with 1,723 additions and 1,140 deletions.
38 changes: 0 additions & 38 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,41 +195,3 @@ jobs:

- name: Test
run: pnpm run test --cache-dir=.turbo --filter !\documentation

strict:
if: ${{ needs.changes.outputs.core_any_changed == 'true' && github.repository == 'siemens/ix' }}
needs: [changes]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/workflows/actions/turbo
- name: Strict
id: report
env:
ALL_CHANGED_FILES: ${{ needs.changes.outputs.core_all_changed_files }}
run: pnpm --filter @siemens/ix exec strict-check ${ALL_CHANGED_FILES}

- name: Find Comment
uses: peter-evans/find-comment@v3
id: find-comment
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
body-includes: '### Report of `strict` check'

- name: Delete comment
if: ${{ steps.report.outputs.has_errors != 'true' }}
uses: actions-cool/issues-helper@v3
with:
actions: 'delete-comment'
token: ${{ secrets.GITHUB_TOKEN }}
comment-id: ${{ steps.find-comment.outputs.comment-id }}

- name: Create or update comment
if: ${{ steps.report.outputs.has_errors == 'true' }}
uses: peter-evans/create-or-update-comment@v4
with:
comment-id: ${{ steps.find-comment.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
body: ${{ steps.report.outputs.body }}
edit-mode: replace
Loading

0 comments on commit 6e41ae3

Please sign in to comment.