Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable property for the components doesn't work properly #1500

Closed
2 tasks done
Yeldece opened this issue Oct 2, 2024 · 1 comment · Fixed by #1519
Closed
2 tasks done

Disable property for the components doesn't work properly #1500

Yeldece opened this issue Oct 2, 2024 · 1 comment · Fixed by #1519
Labels
type: bug Something isn't working

Comments

@Yeldece
Copy link

Yeldece commented Oct 2, 2024

Prerequisites

  • I have read the Contributing Guidelines.
  • I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?

I am a developer using the NVDA screen reader on Windows. Due to my reliance on keyboard navigation, I frequently encounter a bug related to the "disable" attribute in IX components.
Specifically, the "disable" attribute only disables mouse click events. However, this presents a problem for keyboard users. For example, if you have an ixButton or an ixDatepicker, setting a minDate (e.g., today) on the ixDatepicker doesn't fully prevent the selection of an earlier date. Even though the component appears disabled for mouse interactions, keyboard users can still select a date from a year before the minDate.
To reproduce this issue, navigate through the page using only the keyboard, and attempt to click the second button. Check the console log to observe the behavior.

What type of frontend framework are you seeing the problem on?

React

Which version of iX do you use?

v2.5.0

Code to produce this issue.

https://stackblitz.com/edit/ygj7zm-nx8zdp?file=src%2FApp.tsx
@Yeldece Yeldece added the triage We discuss this topic in our internal weekly label Oct 2, 2024
@matthiashader
Copy link
Collaborator

Hello @Yeldece - thanks for your insights.
This has to do with the fact that, in addition to the native button in the web component, the web component itself also has a click listener, which, although blocked via 'pointer-events: none' from being clicked through the UI, can still be clicked programmatically – I have adjusted the button component accordingly. Additionally, I also modified the datepicker component, which generally had an issue with keyboard navigation. (#1519 )

@matthiashader matthiashader added type: bug Something isn't working Workflow: In progress and removed triage We discuss this topic in our internal weekly labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants