Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/chip+pill): add property to display ix-tooltip with customizable text #1697

Merged
merged 29 commits into from
Feb 25, 2025

Conversation

AndreasBerliner
Copy link
Collaborator

@AndreasBerliner AndreasBerliner commented Feb 17, 2025

💡 What is the current behavior?

  • The component text content (ix-chip and ix-pill) is used for the title attribute and the tooltip cannot be customized.

GitHub Issue Number: #

🆕 What is the new behavior?

  • A new property has been added to the ix-chip and ix-pill components to to display an ix-tooltip with customizable text

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 9a8831f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Minor
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-aggrid Patch
@siemens/ix-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AndreasBerliner AndreasBerliner marked this pull request as ready for review February 17, 2025 15:00
nuke-ellington
nuke-ellington previously approved these changes Feb 17, 2025
@AndreasBerliner AndreasBerliner marked this pull request as draft February 18, 2025 10:50
@AndreasBerliner AndreasBerliner marked this pull request as ready for review February 24, 2025 14:50
danielleroux
danielleroux previously approved these changes Feb 25, 2025
@danielleroux danielleroux changed the title feat(chip+pill): add property to customize title attribute for tooltip text feat(core/chip+pill): add property to customize title attribute for tooltip text Feb 25, 2025
@AndreasBerliner AndreasBerliner changed the title feat(core/chip+pill): add property to customize title attribute for tooltip text feat(core/chip+pill): add property to display ix-tooltip with customizable text Feb 25, 2025
jul-lam
jul-lam previously approved these changes Feb 25, 2025
@AndreasBerliner AndreasBerliner dismissed stale reviews from danielleroux and jul-lam via 02f6627 February 25, 2025 12:20
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
nuke-ellington
nuke-ellington previously approved these changes Feb 25, 2025
@nuke-ellington nuke-ellington merged commit 9e13a08 into main Feb 25, 2025
15 checks passed
@nuke-ellington nuke-ellington deleted the tooltip-chip-pill branch February 25, 2025 13:42
This was referenced Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants