Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/radio|checkbox): Jumping input controls #1708

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

lzeiml
Copy link
Collaborator

@lzeiml lzeiml commented Feb 25, 2025

💡 What is the current behavior?

When clicking on a ix-radio or ix-checkbox element, their height changes a few pixels. This results in controls below moving those pixels up or down.

This was caused by elements in both ix-radio and ix-checkbox that were rendered conditionally which resulted in a slight layout shift.

GitHub Issue Number: Closes #1702, IX-2398

🆕 What is the new behavior?

  • ix-radio: div that caused the issue is now displayed using css styling visibility: visible/hidden --> no more layout shift
  • ix-checkbox: svg that caused the issue is now always rendered but it's path is conditional --> no more layout shift

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: b1edcd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add storybook entries for checkbox and radio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"jumping" ix-radio and ix-checkbox (height changes) when clicked
2 participants