-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/radio|checkbox): Jumping input controls #1708
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b1edcd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add storybook entries for checkbox and radio.
|
💡 What is the current behavior?
When clicking on a ix-radio or ix-checkbox element, their height changes a few pixels. This results in controls below moving those pixels up or down.
This was caused by elements in both ix-radio and ix-checkbox that were rendered conditionally which resulted in a slight layout shift.
GitHub Issue Number: Closes #1702, IX-2398
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support