docs(examples): refactor #1239
Merged
docs(examples): refactor #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set up correctly yet
… global.css for test-apps
|
…actor-examples # Conflicts: # package.json # packages/angular-test-app/src/preview-examples/button-ghost.ts # packages/angular-test-app/src/preview-examples/button-loading.ts # packages/angular-test-app/src/preview-examples/button-secondary.ts # packages/angular-test-app/src/preview-examples/button-text-icon.ts # packages/angular-test-app/src/preview-examples/button-with-icon.ts # packages/angular-test-app/src/preview-examples/buttons.ts # packages/angular-test-app/src/preview-examples/icon-toggle-button-secondary-ghost.ts # packages/html-test-app/src/index.html # packages/html-test-app/src/preview-examples/button-ghost.html # packages/html-test-app/src/preview-examples/button-grey-ghost.html # packages/html-test-app/src/preview-examples/button-grey-secondary.html # packages/html-test-app/src/preview-examples/button-grey.html # packages/html-test-app/src/preview-examples/button-loading.html # packages/html-test-app/src/preview-examples/button-secondary.html # packages/html-test-app/src/preview-examples/button-text-icon.html # packages/html-test-app/src/preview-examples/button-with-icon.html # packages/html-test-app/src/preview-examples/buttons.html # packages/html-test-app/src/preview-examples/icon-toggle-button-primary-ghost.html # packages/html-test-app/src/preview-examples/icon-toggle-button-primary-outline.html # packages/html-test-app/src/preview-examples/icon-toggle-button-secondary-ghost.html # packages/html-test-app/src/preview-examples/icon-toggle-button-secondary-outline.html # packages/html-test-app/src/preview-examples/icon-toggle-button-secondary.html # packages/html-test-app/src/preview-examples/toggle-button-primary-ghost.html # packages/html-test-app/src/preview-examples/toggle-button-primary-outline.html # packages/html-test-app/src/preview-examples/toggle-button-secondary-ghost.html # packages/html-test-app/src/preview-examples/toggle-button-secondary-outline.html # packages/html-test-app/src/preview-examples/toggle-button-secondary.html # packages/react-test-app/src/preview-examples/button-ghost.tsx # packages/react-test-app/src/preview-examples/button-loading.tsx # packages/react-test-app/src/preview-examples/button-secondary.tsx # packages/react-test-app/src/preview-examples/button-text-icon.tsx # packages/react-test-app/src/preview-examples/button-with-icon.tsx # packages/react-test-app/src/preview-examples/buttons.tsx # packages/vue-test-app/src/preview-examples/button-ghost.vue # packages/vue-test-app/src/preview-examples/button-loading.vue # packages/vue-test-app/src/preview-examples/button-secondary.vue # packages/vue-test-app/src/preview-examples/button-text-icon.vue # packages/vue-test-app/src/preview-examples/button-with-icon.vue # packages/vue-test-app/src/preview-examples/buttons.vue
Report of
|
…s/refactor-examples
…actor-examples # Conflicts: # packages/angular-test-app/src/app/app-routing.module.ts # packages/angular-test-app/src/app/app.module.ts # packages/core/src/tests/date-dropdown/date-dropdown.e2e.ts-snapshots/date-dropdown-range-options---custom-1-chromium---theme-classic-dark-linux.png # packages/core/src/tests/date-dropdown/date-dropdown.e2e.ts-snapshots/date-dropdown-range-options---custom-1-chromium---theme-classic-light-linux.png # packages/core/src/tests/date-dropdown/date-dropdown.e2e.ts-snapshots/date-dropdown-range-options-1-chromium---theme-classic-dark-linux.png # packages/core/src/tests/date-dropdown/date-dropdown.e2e.ts-snapshots/date-dropdown-range-options-1-chromium---theme-classic-light-linux.png # packages/documentation/docs/controls/_blind_code.md # packages/documentation/docs/controls/flip.md # packages/documentation/docs/controls/grid.md
…s/refactor-examples
danielleroux
requested changes
Aug 13, 2024
packages/core/src/tests/date-picker-rework/year-month-selection/index.html
Outdated
Show resolved
Hide resolved
packages/core/src/tests/date-picker-rework/week-start/index.html
Outdated
Show resolved
Hide resolved
danielleroux
added
Deploy Preview
✅ Deploy Preview for industrial-experience ready!
|
danielleroux
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
The examples are not consistent across the different frameworks, or missing.
JIRA Ticket: IX-1121
GitHub Issue Number: X
🆕 What is the new behavior?
Now, the examples are uniform, present in all frameworks, and have been reformatted.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support
X