-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/tooltip): cutoff near viewport edges #1462
Conversation
🦋 Changeset detectedLatest commit: 1e4020c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Report of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix cause a flicker effect using the steps: #1228
Here a runnable example code:
export class PlaygroundInternal {
componentDidLoad() {
const content = document.createElement('DIV');
content.style.display = 'flex';
content.style.marginTop = '600px';
content.style.marginBottom = '600px';
content.innerHTML = `
<input checked id="checkbox_1_1" name="group_1" type="checkbox" />
<label for="checkbox_1_1"> Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.</label>
<div id="test" style="display: block; width: 5rem; height: 5rem; background: red">
</div>
<ix-tooltip style="align-self: flex-start;" for="#test">Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
</ix-tooltip>
`;
showModal({
content: content,
});
}
render() {
return <Host></Host>;
}
}
💡 What is the current behavior?
flip
alongside placement positions floating-ui/floating-ui#2632GitHub Issue Number: Closes #740, [IX-849], [IX.1206]
🆕 What is the new behavior?
Note
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support