fix(eslint-plugin-defaultvalue): exclude readonly member call express…

…ions
siemens · Jan 22, 2025 · 8e604c4 · 8e604c4
1 parent b456f33
commit 8e604c4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/eslint-plugin-defaultvalue/lib/rules/default-value.ts b/eslint-plugin-defaultvalue/lib/rules/default-value.ts
@@ -194,8 +194,16 @@ const extractCallExpression = (
         // This will never have a defaultValue.
         return undefined;
       }
+      // Should not be documented.
+      if (readonly) {
+        return undefined;
+      }
       return sourceCode.getText(callExpression);
     default:
+      // Should not be documented.
+      if (readonly) {
+        return undefined;
+      }
       return sourceCode.getText(callExpression);
   }
 };

diff --git a/eslint-plugin-defaultvalue/tests/rule-tester.test.ts b/eslint-plugin-defaultvalue/tests/rule-tester.test.ts
@@ -70,7 +70,12 @@ class Test {
   /** @internal */
   internal = 'internal';
 
+  private tempFunc: () => any = () => {};
+  private tempFuncObj = { sub: tempFunc } as const;
+
   readonly dontDefaultValueMe = 42;
+  readonly dontDefaultValueThisCall = this.temp();
+  readonly dontDefaultValueThisMemberCall = this.sub.temp();
   signalValue = input.required<number>();
   modelValue = model<string>();
 }