Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove leftover rules #16

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat: remove leftover rules #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9df3791
feat(eslint-config): remove base eslint formatting rules
Killusions Jan 29, 2025
12efeaa
feat(eslint-configs): drop eslint-plugin-jsdoc
Killusions Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions eslint-config-angular/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import eslintJs from '@eslint/js';
import typescriptEslint from 'typescript-eslint';
import angularEslint from 'angular-eslint';
import jsdocPlugin from 'eslint-plugin-jsdoc';
import perfectionist from 'eslint-plugin-perfectionist';
import preferArrowPlugin from 'eslint-plugin-prefer-arrow';

Expand All @@ -18,8 +17,6 @@ export const configBase = typescriptEslint.config({
...angularEslint.configs.tsRecommended
],
plugins: {
'jsdoc': jsdocPlugin,
'prefer-arrow': preferArrowPlugin,
perfectionist
},
languageOptions: {
Expand Down Expand Up @@ -48,6 +45,9 @@ export const configBase = typescriptEslint.config({
'space-infix-ops': ['off'],
'space-before-blocks': ['off'],

// Disable the recommended formatting rules.
'no-unexpected-multiline': ['off'],

'@typescript-eslint/array-type': ['error'],
'@typescript-eslint/member-ordering': ['off'],
'@typescript-eslint/naming-convention': ['off'],
Expand All @@ -70,34 +70,26 @@ export const configBase = typescriptEslint.config({
'@typescript-eslint/prefer-function-type': ['error'],
'@typescript-eslint/unified-signatures': ['error'],

'array-bracket-spacing': ['error'],
'arrow-parens': ['error', 'as-needed'],
'arrow-spacing': ['error'],
'block-spacing': ['error'],
'curly': ['error'],
'jsdoc/newline-after-description': ['off'],
'key-spacing': ['error'],
'no-duplicate-imports': ['error'],
'no-empty': ['error'],
'no-irregular-whitespace': ['error'],
'no-multi-spaces': ['error'],
'no-multiple-empty-lines': ['error'],
'prefer-arrow/prefer-arrow-functions': ['off'],
'semi-spacing': ['error'],
'space-in-parens': ['error'],
'space-unary-ops': ['error'],
'sort-imports': ['error', { ignoreCase: true, ignoreDeclarationSort: true }]
}
});

export const configRecommended = typescriptEslint.config({
extends: [...angularEslint.configs.tsAll, ...configBase],
plugins: {
'prefer-arrow': preferArrowPlugin
},
rules: {
camelcase: ['off'],
'no-extra-semi': ['off'],
'no-implied-eval': ['off'],
'no-loop-func': ['off'],
'no-useless-constructor': ['off'],
'sort-imports': ['off'],

'perfectionist/sort-imports': [
'error',
{
Expand All @@ -110,6 +102,7 @@ export const configRecommended = typescriptEslint.config({
]
}
],

'@angular-eslint/component-max-inline-declarations': ['off'],
'@angular-eslint/prefer-on-push-component-change-detection': ['off'],
'@angular-eslint/use-component-selector': ['off'],
Expand Down Expand Up @@ -160,7 +153,6 @@ export const configRecommended = typescriptEslint.config({
format: null
}
],

'@typescript-eslint/no-for-in-array': ['error'],
'@typescript-eslint/no-implied-eval': ['error'],
'@typescript-eslint/no-loop-func': ['error'],
Expand All @@ -176,6 +168,7 @@ export const configRecommended = typescriptEslint.config({
}
],
'@typescript-eslint/prefer-optional-chain': ['error'],

'prefer-arrow/prefer-arrow-functions': ['error']
}
});
Expand Down
1 change: 0 additions & 1 deletion eslint-config-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"@eslint/js": "^9.9.1",
"angular-eslint": "^18.1.0 || ^19.0.0",
"eslint": "^9.9.1",
"eslint-plugin-jsdoc": "^50.2.2",
"eslint-plugin-perfectionist": "^4.6.0",
"eslint-plugin-prefer-arrow": "^1.2.3",
"typescript-eslint": "^8.0.0"
Expand Down
27 changes: 10 additions & 17 deletions eslint-config-typescript/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/
import eslintJs from '@eslint/js';
import typescriptEslint from 'typescript-eslint';
import jsdocPlugin from 'eslint-plugin-jsdoc';
import perfectionist from 'eslint-plugin-perfectionist';
import preferArrowPlugin from 'eslint-plugin-prefer-arrow';

Expand All @@ -13,8 +12,6 @@ import preferArrowPlugin from 'eslint-plugin-prefer-arrow';
export const configBase = typescriptEslint.config({
extends: [eslintJs.configs.recommended, ...typescriptEslint.configs.recommended],
plugins: {
'jsdoc': jsdocPlugin,
'prefer-arrow': preferArrowPlugin,
perfectionist
},
languageOptions: {
Expand All @@ -38,6 +35,9 @@ export const configBase = typescriptEslint.config({
'space-infix-ops': ['off'],
'space-before-blocks': ['off'],

// Disable the recommended formatting rules.
'no-unexpected-multiline': ['off'],

'@typescript-eslint/array-type': ['error'],
'@typescript-eslint/member-ordering': ['off'],
'@typescript-eslint/naming-convention': ['off'],
Expand All @@ -60,34 +60,26 @@ export const configBase = typescriptEslint.config({
'@typescript-eslint/prefer-function-type': ['error'],
'@typescript-eslint/unified-signatures': ['error'],

'array-bracket-spacing': ['error'],
'arrow-parens': ['error', 'as-needed'],
'arrow-spacing': ['error'],
'block-spacing': ['error'],
'curly': ['error'],
'jsdoc/newline-after-description': ['off'],
'key-spacing': ['error'],
'no-duplicate-imports': ['error'],
'no-empty': ['error'],
'no-irregular-whitespace': ['error'],
'no-multi-spaces': ['error'],
'no-multiple-empty-lines': ['error'],
'prefer-arrow/prefer-arrow-functions': ['off'],
'semi-spacing': ['error'],
'space-in-parens': ['error'],
'space-unary-ops': ['error'],
'sort-imports': ['error', { ignoreCase: true, ignoreDeclarationSort: true }]
}
});

export const configRecommended = typescriptEslint.config({
extends: [...configBase],
plugins: {
'prefer-arrow': preferArrowPlugin
},
languageOptions: {
parserOptions: {
allowAutomaticSingleRunInference: true
}
},
rules: {
'sort-imports': ['off'],

'perfectionist/sort-imports': [
'error',
{
Expand All @@ -100,6 +92,7 @@ export const configRecommended = typescriptEslint.config({
]
}
],

'@typescript-eslint/naming-convention': [
'error',
{
Expand Down Expand Up @@ -144,7 +137,6 @@ export const configRecommended = typescriptEslint.config({
format: null
}
],

'@typescript-eslint/no-for-in-array': ['error'],
'@typescript-eslint/no-implied-eval': ['error'],
'@typescript-eslint/no-loop-func': ['error'],
Expand All @@ -160,6 +152,7 @@ export const configRecommended = typescriptEslint.config({
}
],
'@typescript-eslint/prefer-optional-chain': ['error'],

'prefer-arrow/prefer-arrow-functions': ['error']
}
});
Expand Down
1 change: 0 additions & 1 deletion eslint-config-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"peerDependencies": {
"@eslint/js": "^9.9.1",
"eslint": "^9.9.1",
"eslint-plugin-jsdoc": "^50.2.2",
"eslint-plugin-perfectionist": "^4.6.0",
"eslint-plugin-prefer-arrow": "^1.2.3",
"typescript-eslint": "^8.0.0"
Expand Down
2 changes: 1 addition & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

export default [
{ ignores: ['dist'] },
{ ignores: ['dist', 'eslint-plugin-defaultvalue/lib/rules/**/*.js'] },
eslintJs.configs.recommended,
{
plugins: { 'headers': eslintPluginHeaders },
Expand Down
Loading