Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): recommend using eslint.config.mjs over eslint.config.js #19

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

spike-rabbit
Copy link
Member

Due to a bug in the eslint-angular builder one had to use type: 'module'. But this bug was fixed.
So I think we should change this in our guide.

That way our recommendation does not interfer with a projects choice using esm or commonjs.

Copy link
Member

@kfenner kfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome that this was fixed. Thank you for the Readme update, looks good to me 🙇 🙏

@kfenner kfenner merged commit fad8e2c into siemens:main Feb 3, 2025
3 checks passed
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants