Skip to content

Commit

Permalink
test: remove unnecessary parameter from visitExample in paging, selec…
Browse files Browse the repository at this point in the history
…tion, and sorting tests
  • Loading branch information
mistrykaran91 committed Feb 3, 2025
1 parent b718908 commit 46fad68
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions playwright/e2e/paging.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test.describe('paging', () => {
const example = 'paging-scrolling-novirtualization';

test(example, async ({ si, page }) => {
await si.visitExample(example, false);
await si.visitExample(example);

await expect(page.locator('ghost-loader')).toBeVisible();
await page.waitForSelector('datatable-row-wrapper');
Expand All @@ -48,7 +48,7 @@ test.describe('paging', () => {
const example = 'server-scrolling';

test(example, async ({ si, page }) => {
await si.visitExample(example, false);
await si.visitExample(example);

await expect(page.locator('ghost-loader')).toBeVisible();
await expect(page.locator('.bar')).toBeVisible();
Expand Down Expand Up @@ -104,13 +104,13 @@ test.describe('paging', () => {
const example = 'virtual-paging';

test(example + ' paginator test', async ({ si, page }) => {
await si.visitExample(example, false);
await si.visitExample(example);
await pagerTest(page, 9);
await si.runVisualAndA11yTests('paginator');
});

test(example, async ({ si, page }) => {
await si.visitExample(example, false);
await si.visitExample(example);

await expect(page.locator('ghost-loader')).toBeVisible();
await expect(page.locator('.custom-loading-content')).toBeVisible();
Expand Down
2 changes: 1 addition & 1 deletion playwright/e2e/selection.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test.describe('selection', () => {
const example = 'cell-selection';

test(example, async ({ si, page }) => {
await si.visitExample(example, false);
await si.visitExample(example);
const nameCell = page.getByRole('cell', { name: 'Ethel Price' });
await expect(nameCell).toBeVisible();

Expand Down
4 changes: 2 additions & 2 deletions playwright/e2e/sorting.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ test.describe('sorting', () => {
test.describe('server side sorting', () => {
const example = 'server-sorting';
test(example, async ({ si, page }) => {
await si.visitExample(example, false);
await si.visitExample(example);

const companyHeader = page.locator('datatable-header-cell[title="Company"]');
const companyHeaderIcon = companyHeader.locator('span').nth(2);
Expand Down Expand Up @@ -138,7 +138,7 @@ test.describe('sorting', () => {
test.describe('custom sorting comparator', () => {
const example = 'comparator-sorting';
test(example, async ({ si, page }) => {
await si.visitExample(example, false);
await si.visitExample(example);

const companyHeader = page.locator('datatable-header-cell[title="Company"]');
const companyHeaderIcon = companyHeader.locator('span').nth(2);
Expand Down

0 comments on commit 46fad68

Please sign in to comment.