Skip to content

Commit

Permalink
docs: accessibility issues pertaining to focus
Browse files Browse the repository at this point in the history
  • Loading branch information
grantwforsythe authored and spike-rabbit committed Feb 3, 2025
1 parent 9bfc763 commit d7f26c2
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 22 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 1 addition & 6 deletions src/app/basic/inline.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,7 @@ import { Employee } from '../data.model';
let-row="row"
>
@if (editing[rowIndex + '-name']) {
<input
autofocus
(blur)="updateValue($event, 'name', rowIndex)"
type="text"
[value]="value"
/>
<input (blur)="updateValue($event, 'name', rowIndex)" type="text" [value]="value" />
} @else {
<span title="Double click to edit" (dblclick)="editing[rowIndex + '-name'] = true">
{{ value }}
Expand Down
1 change: 0 additions & 1 deletion src/app/basic/row-grouping.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ import {
let-rowHeight="rowHeight"
>
<input
autofocus
(blur)="updateValue($event, 'comment', rowIndex)"
type="text"
name="comment"
Expand Down
7 changes: 1 addition & 6 deletions src/app/basic/scrolling-dynamically.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,7 @@ import { Employee } from '../data.model';
let-row="row"
>
@if (editing[rowIndex + '-name']) {
<input
autofocus
(blur)="updateValue($event, 'name', rowIndex)"
type="text"
[value]="value"
/>
<input (blur)="updateValue($event, 'name', rowIndex)" type="text" [value]="value" />
} @else {
<span title="Double click to edit" (dblclick)="editing[rowIndex + '-name'] = true">
{{ value }}
Expand Down
2 changes: 1 addition & 1 deletion src/app/templates/template-dom.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import { Employee } from '../data.model';
</ngx-datatable-column>
<ngx-datatable-column name="Gender">
<ng-template let-column="column" let-sort="sortFn" ngx-datatable-header-template>
<span (click)="sort()">{{ column.name }}</span>
<span tabindex="1" (click)="sort()" (keyup)="sort()">{{ column.name }}</span>
</ng-template>
<ng-template let-row="row" let-value="value" ngx-datatable-cell-template>
My name is: <i [innerHTML]="row['name']"></i> and <i>{{ value }}</i>
Expand Down

0 comments on commit d7f26c2

Please sign in to comment.