Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e for paging, sorting, selection and others #134

Merged

Conversation

mistrykaran91
Copy link
Member

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other. (e2e test )

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Other information:

e2e test for paging, sorting, selection, custom template. Closes #2241

Copy link
Member

@chintankavathia chintankavathia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistrykaran91 Thanks for the PR. I left some comments.

@mistrykaran91 mistrykaran91 force-pushed the test/add-e2e-test-for-ngx-datatable branch from dbf4256 to 466245f Compare January 7, 2025 12:51
@mistrykaran91 mistrykaran91 force-pushed the test/add-e2e-test-for-ngx-datatable branch from 466245f to 9d7afef Compare January 8, 2025 07:16
Copy link
Member

@chintankavathia chintankavathia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@spike-rabbit feel free to review or merge

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2025

CLA assistant check
All committers have signed the CLA.

@spike-rabbit
Copy link
Member

@mistrykaran91 / @chintankavathia it seems like the screenshots are missing on the git-lfs repo. Can you check where they are?

@mistrykaran91 mistrykaran91 force-pushed the test/add-e2e-test-for-ngx-datatable branch 2 times, most recently from 986aca8 to 533f76a Compare January 22, 2025 06:38
@mistrykaran91 mistrykaran91 force-pushed the test/add-e2e-test-for-ngx-datatable branch 4 times, most recently from 0457997 to 2fa1641 Compare January 24, 2025 14:36
@mistrykaran91 mistrykaran91 force-pushed the test/add-e2e-test-for-ngx-datatable branch 3 times, most recently from 8985399 to b718908 Compare January 31, 2025 10:31
@mistrykaran91 mistrykaran91 force-pushed the test/add-e2e-test-for-ngx-datatable branch from 46fad68 to 3d04255 Compare February 3, 2025 11:34
@spike-rabbit spike-rabbit force-pushed the test/add-e2e-test-for-ngx-datatable branch from dc3ed87 to 71600b4 Compare February 3, 2025 13:09
@spike-rabbit
Copy link
Member

thx a lot 🚀

This should help us to move on without creating to many unintended changes.

@spike-rabbit spike-rabbit merged commit cf3e343 into siemens:master Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants