-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e for paging, sorting, selection and others #134
test: add e2e for paging, sorting, selection and others #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mistrykaran91 Thanks for the PR. I left some comments.
dbf4256
to
466245f
Compare
466245f
to
9d7afef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@spike-rabbit feel free to review or merge
@mistrykaran91 / @chintankavathia it seems like the screenshots are missing on the git-lfs repo. Can you check where they are? |
986aca8
to
533f76a
Compare
0457997
to
2fa1641
Compare
8985399
to
b718908
Compare
46fad68
to
3d04255
Compare
dc3ed87
to
71600b4
Compare
thx a lot 🚀 This should help us to move on without creating to many unintended changes. |
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Other information:
e2e test for paging, sorting, selection, custom template. Closes #2241