Test/remove viewport autoscaling #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a leftover from our internal projects. We don't need this here as we run the VRTs always with the entire application
fh1ch
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
@spike-rabbit outstanding work, thanks a ton for the tidy-up 🙇
LGTM 👍
grantwforsythe
pushed a commit
to grantwforsythe/ngx-datatable
that referenced
this pull request
Feb 2, 2025
* test: mark e2e-local-sh as executable * test: remove viewport autoscaling This is a leftover from our internal projects. We don't need this here as we run the VRTs always with the entire application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
We currently resize the viewport in each test based on the content. This behavior was fine for our internal project but causing issues here, as we have very large examples that should actually scroll.
What is the new behavior?
This PR removes the autscaling completely. Instead using a fixed height, which covers all examples that are not intended to scroll.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: