Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow partial overrides of CSS classes #151

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

spike-rabbit
Copy link
Member

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Although the type says diffrently one always needed to set every CSS class.

What is the new behavior?

Now one can only override partial CSS classes and the other defaults will be kept.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

This is part of a larger refactoring to enable strictNullChecks

Copy link
Member

@fh1ch fh1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spike-rabbit really nice work here, thanks a bunch 💯

The changes are all clean and reasonable, no findings from my end.

LGTM 👍

@fh1ch fh1ch merged commit e0cf418 into master Feb 27, 2025
3 checks passed
@fh1ch fh1ch deleted the fix/allow-single-css-overrides branch February 27, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants