refactor: use interface for row properties that may be set by the dat… #153
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
requested review from
timowolf,
kfenner and
fh1ch
as code owners
spike-rabbit
force-pushed
the
refactor/interface-for-row-props
branch
from
9f9e752 to
9fe363c
Compare
spike-rabbit
force-pushed
the
refactor/interface-for-row-props
branch
from
9fe363c to
58e6edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atable
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Some components add properties to the row type if they need it.
This is causing conflicts when passing rows between components if stricter compiler checks are enabled.
What is the new behavior?
There is a common interface for those extra row types. So that we can use it everywhere if needed.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
This is part of a larger refactoring to enable strictNullChecks