Feat/proper types for rows #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
force-pushed
the
feat/proper-types-for-rows
branch
3 times, most recently
from
348353a to
8bff9fa
Compare
timowolf
force-pushed
the
feat/proper-types-for-rows
branch
from
8bff9fa to
80568eb
Compare
|
LGTM |
spike-rabbit
added a commit
that referenced
this pull request
Apr 29, 2024
This reverts commit 1641b94.
timowolf
pushed a commit
that referenced
this pull request
Apr 29, 2024
spike-rabbit
added a commit
that referenced
this pull request
Apr 29, 2024
* feat: use proper type for row related properties * fix: detect update in rows automatically if row identity changed * perf: only detect changes in rows on real changes * docs: use row related types in examples
spike-rabbit
added a commit
that referenced
this pull request
Aug 20, 2024
* feat: use proper type for row related properties * fix: detect update in rows automatically if row identity changed * perf: only detect changes in rows on real changes * docs: use row related types in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
There were almost no types. I basically added types row Rows.
While doing this I noticed a bug with the row differ, where I am not sure about the impact.
What is the new behavior?
Most things related to rows are now typed. This is done by having a generic global TRow type.
As this is defaulted to any, there should be no breaking change. Although I have to admit that this could be breaking.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Applications may need to adopt their types.
Other information:
Some new internal types like
TRow extends {level?: number}are not perfect yet. As optimizing this would create more noise, I prefer doing this in a later MR