Skip to content

Fixes #14119 - Adjust bottom margin of bottomActionBar… #14122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgmltn
Copy link

@dgmltn dgmltn commented May 3, 2025

… in ConversationListFragment, CallLogFragment to accomodate nav bar

Contributor checklist

  • Pixel 9, Android SDK 35
  • Virtual device "Pixel 4a", Android SDK 30
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This adds a bottom margin to the bottomActionBar inside ConversationListFragment and CallLogFragment (via SignalBottomActionBarController) to accomodate Navigation Bars.

  • I was a bit concerned that the SignalBottomActionBarController change would affect other bottom actionbars but I confirmed that it's used only inside the CallLogFragment.
  • I tested on SDK 30 using both gesture navigation and 3 button navigation to make sure the nav bar height calculation was correct (even though ViewUtil.getNavigationBarHeight already existed).
  • I used my judgement to determine an extra padding of 8dp between the nav bar and action bar looked the best. 16dp seemed too big.
  • I considered moving adjustBottomMarginForNavBar to ViewUtil (especially since it just calls 3 ViewUtil methods anyway) but it seemed too specific to this use case. I could be convinced to move it there. LMK

…nversationListFragment, CallLogFragment to accomodate nav bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants