Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define profiling.instrumentation.source Log Message Attribute #336

Closed
wants to merge 6 commits into from
Closed

Define profiling.instrumentation.source Log Message Attribute #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb6ca73
Define an attribute for distinguising which profiling extension colle…
tduncan Feb 17, 2025
5047b14
Update changlog with profiling instrumentation source attribute addit…
tduncan Feb 17, 2025
1d4834d
Add additional context for the 'profiling'instrumentation.source' att…
tduncan Feb 17, 2025
bf46921
Update CHANGELOG.md
tduncan Feb 17, 2025
f5508e2
Update specification/semantic_conventions.md
tduncan Feb 17, 2025
facce30
Update CHANGELOG.md
pellared Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

## [Unreleased]

### Semantic Conventions

#### Enhancements

- Define the `profiling.instrumentation.source` attribute with valid values
of `continuous` and `snapshot`.
[#336](https://github.com/signalfx/gdi-specification/pull/336)

## [1.7.0] - 2025-01-07

### Configuration
Expand Down
3 changes: 3 additions & 0 deletions specification/semantic_conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ instances. For each `LogRecord` instance:
- `pprof-gzip-base64`,
- `text` ([Deprecated](../README.md#versioning-and-status-of-the-specification)
format).
- `profiling.instrumentation.source` MUST be set to either:
- `continuous` for continuous "Always On" profiling
- `snapshot` for trace snapshot profiling
Comment on lines +132 to +134
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that, for backward compatibility, you should mention that it will be treated as continuous.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, there are too many existing installations, my suggestion is that profiling.instrumentation.source must only be set when anything other than continuous is used (as the backend treats all of the profiles as continuous by default).


#### `LogRecord` Message `text` Data Format Specific Attributes

Expand Down