Remove more gossipsub duplicate warnings

[michaelsproul]

Description

This PR #5163 removes some warnings, but doesn't cover this case:

WARN Gossip message publish failed on retry error: Duplicate, topic: beacon_attestation, service: libp2p

Relevant code is here:

lighthouse/beacon_node/lighthouse_network/src/service/mod.rs

Lines 1222 to 1245 in c7e5dd1

	match self
	.swarm
	.behaviour_mut()
	.gossipsub
	.publish(Topic::from(topic.clone()), data)
	{
	Ok(_) => {
	warn!(self.log, "Gossip message published on retry"; "topic" => topic_str);
	if let Some(v) = metrics::get_int_counter(
	&metrics::GOSSIP_LATE_PUBLISH_PER_TOPIC_KIND,
	&[topic_str],
	) {
	v.inc()
	};
	}
	Err(e) => {
	warn!(self.log, "Gossip message publish failed on retry"; "topic" => topic_str, "error" => %e);
	if let Some(v) = metrics::get_int_counter(
	&metrics::GOSSIP_FAILED_LATE_PUBLISH_PER_TOPIC_KIND,
	&[topic_str],
	) {
	v.inc()
	};
	}

There are 3 cases, and I think we should warn in at most 2 of them:

• Message published successfully on retry: warn? because it was probably published late? no warn? because these logs are annoying af?
• Message failed to publish because it was a duplicate: no warn.
• Message failed to pubish at all: warn.

Version

Lighthouse v4.6.0

Additional Info

The Gossip message publish failed on retry is much more common on our infra, with 50M occurrences in the last month across our infra. By comparion, Gossip message published on retry has only 27k occurrences, it seems mostly after a node restarting.

[paulhauner]

Resolved via #5235