Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct reward denominator in op pool #5047

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Closes #5016

Proposed Changes

The op pool was using the wrong denominator when calculating proposer block rewards! This was mostly inconsequential as our studies of Lighthouse's block profitability already showed that it is very close to optimal. The wrong denominator was leftover from phase0 code, and wasn't properly updated for Altair.

Additional Info

After this change there is better agreement between /lighthouse/analysis/block_rewards and the standard rewards API, however they are not yet calculating identical results because of how the per-attestation rewards are rounded in /lighthouse/analysis/block_rewards. A more extensive refactor of the max cover code to divide by the denominator after grouping attesters by attestation would fix this discrepancy.

E.g.

slot 8161659: block from lighthouse-subscribe-none with 64 attestations & purported reward 42231047 gwei
slot 8161658: canonical <=> lighthouse-subscribe-none distance: 4636
slot 8161658: canonical block is likely Lighthouse@4636 (two closest match)
rewards from lighthouse-subscribe-none: 42227080 gwei (att: 40729402 gwei)
most profitable block from ["lighthouse-subscribe-none"]

I'm not sure if this change is worth making yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress PR is a work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant