Fix asset paths in release CI upload job #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
bug
|
v4.6.111-exp building here 🤞 https://github.com/sigp/lighthouse/actions/runs/7496800413 |
michaelsproul
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix the failure of the release CI job due to incorrect paths. The
v4.6.0-rc.0release failed for this reason: https://github.com/sigp/lighthouse/actions/runs/7482170659/job/20366908168Proposed Changes
The release artifacts are downloaded into directories with the same names as the files. This PR updates the paths to include the containing directories.
I tested this fix already for the
v4.5.444-exprelease but forgot to backport it tounstable: https://github.com/sigp/lighthouse/actions/runs/6582951657I'm about to run a
v4.6.111-exprelease for tree-states which will provide more up-to-date testing.