release: remove pip cache usage #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
jku
approved these changes
May 18, 2024
There was a problem hiding this comment.
That makes sense.
There's several other things we could do to make the release more auditable and reproducible:
- smoke test should happen in a separate job -- venv is not a security barrier so all our runtime deps are now in a way release process dependencies as well
- preferably build and the actual build plugin would be pinned... this is a bit annoying to do though (because the build plugin is installed inside build, see example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely a defense in depth maneuver: an attacker could only poison our cache here by running arbitrary code on
main. But we probably shouldn't be caching anyways, since it makes the release process/state more opaque 🙂Context: https://adnanthekhan.com/2024/05/06/the-monsters-in-your-build-cache-github-actions-cache-poisoning/