Skip to content

dsse: add Envelope._from_json #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2024
Merged

dsse: add Envelope._from_json #1039

merged 3 commits into from
Jun 6, 2024

Conversation

woodruffw
Copy link
Member

Adds _from_json and __eq__ to Envelope.

_from_json is currently a private API, since there have been no public third-party requests for it yet. But it could be made public in a minor release without any problems.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw added enhancement New feature or request component:api Public APIs labels Jun 5, 2024
@woodruffw woodruffw self-assigned this Jun 5, 2024
@woodruffw woodruffw requested a review from jku June 5, 2024 21:58
Signed-off-by: William Woodruff <william@trailofbits.com>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woodruffw woodruffw enabled auto-merge (squash) June 6, 2024 13:24
@woodruffw woodruffw merged commit 28237a4 into main Jun 6, 2024
24 checks passed
@woodruffw woodruffw deleted the ww/dsse-apis branch June 6, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api Public APIs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants