Update embedded TUF root #1300
Merged
Update embedded TUF root #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes client a little snappier on first launch. This is the result of:
python -m sigstore sign README.md
cp ~/.local/share/sigstore-python/tuf/https%3A%2F%2Ftuf-repo-cdn.sigstore.dev/root.json \
sigstore/_store/prod/root.json
cp ~/.cache/sigstore-python/tuf/https%3A%2F%2Ftuf-repo-cdn.sigstore.dev/trusted_root.json \
sigstore/_store/prod/trusted_root.json
This uses sigstore-python to update the local TUF cache during the
signing, then embeds the new good TUF root (and trusted root) in the
source dir
This is also a good way for others to verify this PR is correct
(just remember to run python-sigstore from current main, only then
switch to PR branch)
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
woodruffw
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks, LGTM! I confirmed locally as well as against https://tuf-repo-cdn.sigstore.dev/.
Random thought: it'd be nice to have make bump-embedded-root or similar to automate this in the future. We could then stick it in the CI on a cron trigger 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes client a little snappier on first launch. This is the result of:
This uses sigstore-python to update the local TUF cache during the signing, then embeds the new good TUF root (and trusted root) in the source dir
The above is also a good way for others to verify this PR is correct (just run python-sigstore from current main first, only then switch to PR branch)