Skip to content

[DRAFT] Add RekorV2Client #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented May 20, 2025

Client support for Rekor V2: sigstore-python #289

Summary

Adds a new RekorV2Client class, for use as a library, not yet within the CLI.

With the same pending TODOs in #1387

  • We are embedding the auto-generated types until we can find a home for them

Testing

  • Unit tests that call live instances of RekorV2, only "alpha" for now
  • Lints are not yet expected to pass, mainly due to type hints on the copy-pasted auto-generated types.

TODOS

  • add more client methods: get_tile, get_entry_bundle, get_checkpoint.
  • enable testing against more instances: staging, prod, local
  • add extra assert in test after improve KindVersion compatibility #1370
  • use these types in sigstore/protobuf-specs when ready (hopefully this week of May 19, 2025)
  • remove workaround where the ...V_0_0_2 is changed to ...V002
  • prefer sending the certificate, rather than the public key to Rekor

Release Note

  • Added a RekorV2Client for posting new entries to a Rekor V2 instance.

Documentation

TODO

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 changed the title Add RekorV2Client [DRAFT] Add RekorV2Client May 20, 2025
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants